Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump com.pinterest.ktlint:ktlint-bom from 1.2.1 to 1.3.1 #1321

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Bumps com.pinterest.ktlint:ktlint-bom from 1.2.1 to 1.3.1.

Release notes

Sourced from com.pinterest.ktlint:ktlint-bom's releases.

1.3.1

🔧 Fixes

📦 Dependencies

💬 Other

1.3.0

🆕 Features

🔧 Fixes

... (truncated)

Changelog

Sourced from com.pinterest.ktlint:ktlint-bom's changelog.

[1.3.1] - 2024-07-02

🔧 Fixes

📦 Dependencies

💬 Other

[1.3.0] - 2024-06-04

🆕 Features

🔧 Fixes

... (truncated)

Commits
  • 49f376b Prepare release 1.3.1 (#2730)
  • 17a240d Fix documentation class-signature (#2729)
  • 91d8d44 Fix "unset" value for property ktlint_chain_method_rule_force_multiline_when_...
  • 15fb36d Fix false alert `Format was not able to resolve all violations which (theoret...
  • 52534ca Ignore suppressions for no-unused-imports rule (#2725)
  • abb24b9 Ignore suppressions for no-unused-imports rule (#2720)
  • e7cecd3 Update dependency org.junit.jupiter:junit-jupiter to v5.10.3 (#2721)
  • 6f0a313 Fix false positive when primary constructor has no arguments and a secondary ...
  • 5fb8373 Fix suppression handling when 'formatter:on' not properly specified (#2719)
  • 2ecb753 Fix false positive when anonymous function is used as value argument (#2718)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.pinterest.ktlint:ktlint-bom](https://github.com/pinterest/ktlint) from 1.2.1 to 1.3.1.
- [Release notes](https://github.com/pinterest/ktlint/releases)
- [Changelog](https://github.com/pinterest/ktlint/blob/master/CHANGELOG.md)
- [Commits](pinterest/ktlint@1.2.1...1.3.1)

---
updated-dependencies:
- dependency-name: com.pinterest.ktlint:ktlint-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@SimonMarquis SimonMarquis requested a review from a team as a code owner October 1, 2024 18:45
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.10.2 Build Scan not published

> Format was not able to resolve all violations which (theoretically) can be autocorrected in file Swipeable.kt in 3 consecutive runs of format
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.10.2 Build Scan not published

@SimonMarquis
Copy link
Member

I'm not fan of some of the changes introduced in this update (like this one, or this one)...
Also, I think we should probably disable ktlint on files that are exact copies of AndroidX source code.
WDYT @soulcramer?

@soulcramer
Copy link
Contributor

I agree…

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2024

A newer version of com.pinterest.ktlint:ktlint-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@SimonMarquis SimonMarquis merged commit 4d5c7b9 into main Oct 31, 2024
8 checks passed
@SimonMarquis SimonMarquis deleted the dependabot/gradle/com.pinterest.ktlint-ktlint-bom-1.3.1 branch October 31, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants