feat(API): bump compileSdk & targetSdk to API level 35 (Android 15) #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
approved these changes
Nov 13, 2024
SimonMarquis
commented
Nov 13, 2024
| @@ -137,6 +137,7 @@ public fun ModalScaffold( | |||
| ) | |||
| val activityWindow = getActivityWindow() | |||
|
|
|||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
@soulcramer do we need to do something about these APIs being used while deprecated? Are they still working as expected?
There was a problem hiding this comment.
I checked and without them it works as expected with edge-to-edge and without 🤷
There was a problem hiding this comment.
On all API levels you mean? (pre&post forced edge-to-edge)
There was a problem hiding this comment.
yes I tested it on my emulator on 31 but I did not tested it without gestures, I'll try with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Bump
compileSdk&targetSdkto API level 35 (Android 15).🤔 Context
Closes #1368