fix: Refactor color tokens #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new mandatory Tokens: Basic and Accent, with their variations and states - Adopt the new brand colors from Adevinta (remove TheBlue, SugarCotton, Surfer. add BlueRibbon, Violet, PaleAdevinta, BlackAdevinta) - Apply the new brand colors to the themes - Introduce main and support color tokens instead of primary and secondary (mark the latter @deprecated)
Keep deprecated Primary and Secondary for Buttons and Tags, as their adoption might be already quite significant)
Add new default Intent Color - Current
SimonMarquis
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntentColorsto make sure all components use right color tokens🤔 Context
Explore the complete discussion in this Figma file and this Presentation
📸 Screenshots
Present in the current PR
🗒️ Other info
related to spark-tokens update
close #555