Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use dim3 for all components to handle disabled state #587

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

MarinaRomanova
Copy link
Contributor

@MarinaRomanova MarinaRomanova commented Aug 2, 2023

📋 Changes description

Update

  • Buttons
  • Chips
  • Tabs
  • Toggles
    to use disabledextension property that applies dim3composite overs SparkTheme.colors.surface to avoid unwanted transparency

🤔 Context

Some of the components used

  • dim3
  • container colors
    for disabled states.
    This refactoring allows to ensure the coherent styling

📸 Screenshots

Present in the current PR
image

🗒️ Other info

close #575

Copy link
Contributor

@soulcramer soulcramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are your sure about this change?
From what I understood from our meeting is that we would apply a disabled alpha to the whole component instead of composing it in some places 🤔

@soulcramer
Copy link
Contributor

Otherwise LGTM ping me again later

@MarinaRomanova
Copy link
Contributor Author

Yes, on the web dim applied differently. But we have to ensute the component is not transparent.

@MarinaRomanova MarinaRomanova merged commit 8b65c68 into main Aug 3, 2023
6 checks passed
@MarinaRomanova MarinaRomanova deleted the intents/disabled-color branch August 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update disabled colors for all components
2 participants