fix: ModalFullScreenScaffold has now a spacing between button in portrait and add reverse order #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
requested review from
MarinaRomanova and
SimonMarquis
as code owners
MarinaRomanova
previously approved these changes
Aug 4, 2023
…rait and add reverse order
soulcramer
force-pushed
the
modal-fix-padding
branch
from
e7eee4c
to
16ab0cc
Compare
SimonMarquis
reviewed
Aug 4, 2023
spark/src/main/kotlin/com/adevinta/spark/components/dialog/ModalFullScreenScaffold.kt
Outdated
Show resolved
Hide resolved
…alFullScreenScaffold.kt Co-authored-by: Simon Marquis <[email protected]>
SimonMarquis
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes description
Add spacing to buttons and add a new
reverseButtonOrderparam to, like its name indiquate, reverse the order between the support and main button.🤔 Context
As mentioned here a spacing was missing between buttons in portrait mode
📸 Screenshots
🗒️ Other info
Close #546