Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add IconButtons with all intents, shapes and sizes #612

Merged
merged 9 commits into from
Aug 17, 2023
Merged

feat: Add IconButtons with all intents, shapes and sizes #612

merged 9 commits into from
Aug 17, 2023

Conversation

MarinaRomanova
Copy link
Contributor

@MarinaRomanova MarinaRomanova commented Aug 10, 2023 •
edited
Loading

📋 Changes description

  • Add new iconbutton package containing styled icon buttons:
    • IconButtonFilled
    • IconButtonOutlined
    • IconButtonTinted
    • IconButtonGhost
    • IconButtonContrast
  • with all sizes, intents and shape
  • deprecate old IconButtons from icons package.
  • Replace IconButton used in ModalFullScreen component
  • update min touch size from 48.dp to 44.dp as per Saprk specs
  • Add configurable example for IconButton

📸 Screenshots

  • Present in the current PR for the component.
  • CatalogApp:

🗒️ Other info

Old Icon Button was used in a number of places:

  • SelectTextField
  • BottomAppBar
  • DropdownMenu
  • Scaffold
    These cases should be eventually updated to use the new IconButton

close #573
close #574
close #610

SimonMarquis
SimonMarquis reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@SimonMarquis SimonMarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need these @file:Suppress("DEPRECATION").
They will hide precious information by suppressing every deprecation warning in the files.

@MarinaRomanova
Copy link
Contributor Author

MarinaRomanova commented Aug 11, 2023 •
edited
Loading

@file:Suppress("DEPRECATION") is needed to avoid throwing error for components that are still using the old IconButton. To replace it, we will need updated specs, but we do not have those yet.

kazaky
kazaky approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@kazaky kazaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarinaRomanova MarinaRomanova enabled auto-merge (squash) August 17, 2023 08:02
@MarinaRomanova MarinaRomanova merged commit c0b28f6 into main Aug 17, 2023
5 checks passed
@MarinaRomanova MarinaRomanova deleted the icon-buttons branch August 17, 2023 08:13
soulcramer added a commit that referenced this pull request Aug 17, 2023
@soulcramer
Revert "feat: Add IconButtons with all intents, shapes and sizes (#612)"
4ffc1f9 
This reverts commit c0b28f6.
soulcramer pushed a commit that referenced this pull request Aug 17, 2023
@MarinaRomanova @soulcramer
feat: Add IconButtons with all intents, shapes and sizes (#612)
e915ec3 
(cherry picked from commit c0b28f6)
@soulcramer soulcramer mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMarquis SimonMarquis SimonMarquis left review comments

@kazaky kazaky kazaky approved these changes

@soulcramer soulcramer Awaiting requested review from soulcramer soulcramer is a code owner

Assignees

@MarinaRomanova MarinaRomanova

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MarinaRomanova @SimonMarquis @kazaky