Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes for release 0.4.0 #618

Merged
merged 6 commits into from
Aug 17, 2023
Merged

fix: fixes for release 0.4.0 #618

merged 6 commits into from
Aug 17, 2023

Conversation

soulcramer
Copy link
Contributor

📋 Changes description

Remove visibility to Composite Previews from Spark and remove SparkPreviewProvider

🤔 Context

These are needed to merge this version in the polaris app

SimonMarquis
SimonMarquis previously approved these changes Aug 16, 2023
@github-actions
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

@soulcramer soulcramer merged commit abcc4fb into main Aug 17, 2023
5 checks passed
@soulcramer soulcramer deleted the fix-spark branch August 17, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants