Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the readonly Textfields not take the focus look when focused #647

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

soulcramer
Copy link
Contributor

📋 Changes description

Made the readonly=false required for the TextfField to look focused

🤔 Context

The textfield was using it's focused style in read only, now it need to not be read only before to have this visual.

📸 Screenshots

Screen_recording_20230822_151754.mp4

🗒️ Other info

Close #633

@soulcramer soulcramer added the Bug Bug to fix label Aug 22, 2023
@soulcramer soulcramer self-assigned this Aug 22, 2023
@SimonMarquis SimonMarquis changed the title fix: Make the readonly Textfields not take the focus looked when focused fix: Make the readonly Textfields not take the focus look when focused Aug 22, 2023
@soulcramer soulcramer merged commit c779da6 into main Aug 22, 2023
6 checks passed
@soulcramer soulcramer deleted the bug-textfield branch August 22, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] The TextField readonly flag doesn't block it from taking focus
2 participants