Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add IconButton screenshot test #674

Closed
wants to merge 10 commits into from

Conversation

MarinaRomanova
Copy link
Contributor

📋 Changes description

  • Add Screenshot test for IconButtons
  • Remove previews of IconButtons for non-default sizes

🤔 Context

We have agreed to add screnshot test with Paparazzi rather than adding numerous Previews.

  • Configurator part in CatalogApp is meant to be used to see the component with all available properties.
  • Paparazzi should be used for regression tests

📸 Screenshots

Present in the current PR

@MarinaRomanova MarinaRomanova enabled auto-merge (squash) August 25, 2023 10:00
@SimonMarquis
Copy link
Member

Do we really need this many images? 🙈
Is there a way we can merge things?

@MarinaRomanova
Copy link
Contributor Author

I refactored the grouping, we have much less now 😁

@soulcramer soulcramer closed this Sep 7, 2023
auto-merge was automatically disabled September 7, 2023 16:07

Pull request was closed

@soulcramer soulcramer deleted the icon-buttons/screenshot-test branch March 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants