Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(catalog): Add illustrations for components item #715

Merged
merged 6 commits into from
Sep 19, 2023
Merged

feat(catalog): Add illustrations for components item #715

merged 6 commits into from
Sep 19, 2023

Conversation

soulcramer
Copy link
Contributor

@soulcramer soulcramer commented Sep 8, 2023 •
edited
Loading

📋 Changes description

  • Add illustrations.
  • Add keep file as the tokens illustration is marked as not reachable by R8 and for some reason shift all drawables.
  • Use only one Component composable
  • Add a tag to indicate the number of examples by components
  • Add a scrim to have the tag and the label still lisible if the illustration is big enough to cover them.

🤔 Context

i made the illustration myself and made them kind of ugly/dirty to have a small silly look and feel 🤷

📸 Screenshots

image

🗒️ Other info

Close #714

@soulcramer soulcramer added the CatalogApp Related to the demo app label Sep 8, 2023
@soulcramer soulcramer self-assigned this Sep 8, 2023
kazaky
kazaky approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@kazaky kazaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soulcramer soulcramer merged commit 15c6579 into main Sep 19, 2023
5 checks passed
@soulcramer soulcramer deleted the catalo-examples-images branch September 19, 2023 14:59
@SimonMarquis SimonMarquis mentioned this pull request Sep 20, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazaky kazaky kazaky approved these changes

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis is a code owner

Assignees

@soulcramer soulcramer

Labels
CatalogApp Related to the demo app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add illustrations or a component preview for examples & configurator
2 participants
@soulcramer @kazaky