Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Create S3 bucket for doc upload #72

Merged
merged 8 commits into from
Nov 23, 2020
Merged

Conversation

SarahJaine
Copy link
Collaborator

Description of change

  • Update terraform code to create s3 buckets to use for document upload (a field in the activity report)
  • Create service binding for s3 buckets

How to test

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] Documentation updated - documentation on service binding added in CD: Bind RDS instance #71

Copy link

@jasalisbury jasalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only have one comment but no need to hold up this PR for it.

terraform/dev/main.tf Show resolved Hide resolved
@SarahJaine SarahJaine merged commit 5f5fc52 into main Nov 23, 2020
@SarahJaine SarahJaine deleted the sj-tf-s3-init branch November 23, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants