Navigator feedback #84
Conversation
* Change navigator status colors to be more accessible * Page titles are now most specific to least specific * Add navigator test making sure "complete" state is shown * Fix cucumber test to look for proper label * Activity report uses proper label for "grantee/non-grantee name(s)"
| userEvent.click(screen.getByRole('button', { name: 'Continue' })); | ||
| await screen.findByTestId('second'); | ||
| const navItem = await screen.findByText('first page'); | ||
| await waitFor(() => expect(within(navItem.nextSibling).getByText('Complete')).toBeVisible()); |
There was a problem hiding this comment.
This actually confused me more. Why is this first step complete when it was "in progress" during the other test?
There was a problem hiding this comment.
In the first test the user fills out some of the first page but never completes the first page by clicking the Continue button, they navigate via the side navigation to the second page. Pages are "Complete" only when the Continue button is pressed. The continue button is disabled unless the form is valid (all required fields have valid values).
In the second test the first page is valid because there are no required form fields, so the Continue button is active and sets the first page as "Complete" when clicked.
I decided against setting pages as "Complete" automatically when the form is valid. If we automatically set the form to valid after all required fields have valid values there is the potential for users to miss filling in optional fields.
There was a problem hiding this comment.
Ahhhh, ok.
I'm not 100% certain I like that limitation of only switching if you navigate with the button and not the nav menu, but I definitely see your point about optional fields so it's something we should address with more research and another story.
Description of change
Address feedback from HHS#190
How to test
Notes
It might be worth it to get HHS#159 finished soon to prevent accessibility issues sooner.
Issue(s)
Checklist