Add review page accordions #96
Conversation
* Date picker now accepts a string MM/DD/YYYY and spits out the same * Each page defines sections that are used in the review accordion * Simplified how the activity report imports the pages for the report
| <Button className="stepper-button" type="submit" disabled={!formState.isValid}>Continue</Button> | ||
| <Button type="submit" disabled={!formState.isValid}>Continue</Button> |
There was a problem hiding this comment.
Removing CSS class that was doing nothing, missed it in a previous PR
| .smart-hub--navigator-item:first-child .smart-hub--navigator-link-active { | ||
| border-top-right-radius: 4px; | ||
| } | ||
|
|
||
| .smart-hub--navigator-item:last-child .smart-hub--navigator-link-active { | ||
| border-bottom-right-radius: 4px; | ||
| } |
There was a problem hiding this comment.
Fixing slight style issue on the navigator's side nav where the border radius is squared when the first or last element is selected
| @@ -307,4 +311,73 @@ ActivitySummary.propTypes = { | |||
| control: PropTypes.object.isRequired, | |||
| }; | |||
|
|
|||
| export default ActivitySummary; | |||
| const sections = [ | |||
There was a problem hiding this comment.
There appears to be the potential for defining the whole form in an object similar to this one and simplifying the ~300 lines of code above, but that would be a bigger project then we have the capacity to tackle at this point.
|
The accordion and the summary look great! 🚀 At some point (for a different PR) I can see a request to preserve the expanded state on the accordion when navigating away and coming back. Minor item on this PR. Can we add a bit more space between the label and the multiselect for the managers? |
Conflicts: .circleci/config.yml package.json src/routes/apiDirectory.js
Description of change
The review page now has an accordion with an item for each page that matches the desired design. The report still needs to be marked as
Submittedin the backend after saving of a report (HHS#98) is closed.How to test
Sandbox:
Test on https://tta-smarthub-sandbox.app.cloud.gov/activity-reports/review. Note the "approvers" section isn't working correctly because the seed files aren't being loaded in for this branch. Once #78 is merged the approvers select box will work.
Local:
Issue(s)
Checklist