refac: remove referrer from ADJDeeplink for now

adjust · Aug 2, 2024 · f1b42fc · f1b42fc
1 parent b911a2a
commit f1b42fc
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 35 deletions.
diff --git a/Adjust/ADJDeeplink.h b/Adjust/ADJDeeplink.h
@@ -12,8 +12,6 @@
 
 @property (nonatomic, copy, readonly, nonnull) NSURL *deeplink;
 
-@property (nonatomic, copy, nullable) NSURL *referrer;
-
 - (nullable ADJDeeplink *)initWithDeeplink:(nonnull NSURL *)deeplink;
 
 @end
diff --git a/Adjust/Adjust.m b/Adjust/Adjust.m
@@ -401,8 +401,7 @@ - (void)processDeeplink:(ADJDeeplink *)deeplink {
     [ADJUserDefaults cacheDeeplinkUrl:deeplink.deeplink];
     NSDate *clickTime = [NSDate date];
     if (![self checkActivityHandler]) {
-        [ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink 
-                             referrerUrl:deeplink.referrer
+        [ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink
                                clickTime:clickTime];
         return;
     }
@@ -421,7 +420,6 @@ - (void)processAndResolveDeeplink:(nonnull ADJDeeplink *)deeplink
     NSDate *clickTime = [NSDate date];
     if (![self checkActivityHandler]) {
         [ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink
-                             referrerUrl:deeplink.referrer
                                clickTime:clickTime];
         self.cachedResolvedDeeplinkBlock = completion;
         return;

diff --git a/Adjust/Internal/ADJActivityHandler.m b/Adjust/Internal/ADJActivityHandler.m
@@ -401,7 +401,6 @@ - (void)processDeeplink:(ADJDeeplink *)deeplink withClickTime:(NSDate *)clickTim
                      block:^(ADJActivityHandler * selfI) {
                          [selfI processDeeplinkI:selfI
                                              url:deeplink.deeplink
-                                        referrer:deeplink.referrer
                                        clickTime:clickTime];
                      }];
 }
@@ -415,7 +414,6 @@ - (void)processAndResolveDeeplink:(ADJDeeplink * _Nullable)deeplink
         selfI.cachedDeeplinkResolutionCallback = completion;
         [selfI processDeeplinkI:selfI
                             url:deeplink.deeplink
-                       referrer:deeplink.referrer
                       clickTime:clickTime];
     }];
 }
@@ -1168,12 +1166,9 @@ - (void)processCachedDeeplinkI:(ADJActivityHandler *)selfI {
     if (cachedDeeplinkClickTime == nil) {
         return;
     }
-    // referrer URL can be nil
-    NSURL *cachedDeeplinkReferrerUrl = [ADJUserDefaults getDeeplinkReferrerUrl];
 
     [selfI processDeeplinkI:selfI 
                         url:cachedDeeplinkUrl
-                   referrer:cachedDeeplinkReferrerUrl
                   clickTime:cachedDeeplinkClickTime];
     [ADJUserDefaults removeDeeplink];
 }
@@ -1924,7 +1919,6 @@ - (void)checkStatusI:(ADJActivityHandler *)selfI
 
 - (void)processDeeplinkI:(ADJActivityHandler *)selfI
                      url:(NSURL *)deeplink
-                referrer:(NSURL *)referrer
                clickTime:(NSDate *)clickTime {
     if (![selfI isEnabledI:selfI]) {
         return;
@@ -1968,9 +1962,6 @@ - (void)processDeeplinkI:(ADJActivityHandler *)selfI
     clickBuilder.attribution = deeplinkAttribution;
     clickBuilder.clickTime = clickTime;
     clickBuilder.deeplink = [deeplink absoluteString];
-    if (referrer != nil) {
-        clickBuilder.deeplinkReferrer = [referrer absoluteString];
-    }
 
     ADJActivityPackage *clickPackage = [clickBuilder buildClickPackage:@"deeplink"];
     [selfI.sdkClickHandler sendSdkClick:clickPackage];

diff --git a/Adjust/Internal/ADJPackageBuilder.h b/Adjust/Internal/ADJPackageBuilder.h
@@ -20,8 +20,6 @@
 
 @property (nonatomic, copy) NSString * _Nullable deeplink;
 
-@property (nonatomic, copy) NSString * _Nullable deeplinkReferrer;
-
 @property (nonatomic, copy) NSString * _Nullable reftag;
 
 @property (nonatomic, copy) NSDate * _Nullable clickTime;

diff --git a/Adjust/Internal/ADJPackageBuilder.m b/Adjust/Internal/ADJPackageBuilder.m
@@ -604,7 +604,6 @@ - (NSMutableDictionary *)getClickParameters:(NSString *)source {
     [ADJPackageBuilder parameters:parameters setDictionary:self.deeplinkParameters forKey:@"params"];
     [ADJPackageBuilder parameters:parameters setDictionary:[self.globalParameters.partnerParameters copy] forKey:@"partner_params"];
     [ADJPackageBuilder parameters:parameters setDate:self.purchaseTime forKey:@"purchase_time"];
-    [ADJPackageBuilder parameters:parameters setString:self.deeplinkReferrer forKey:@"referrer"];
     [ADJPackageBuilder parameters:parameters setDate:[ADJUserDefaults getSkadRegisterCallTimestamp] forKey:@"skadn_registered_at"];
     [ADJPackageBuilder parameters:parameters setString:source forKey:@"source"];
     [ADJPackageBuilder parameters:parameters setDate1970:(double)self.packageParams.startedAt forKey:@"started_at"];

diff --git a/Adjust/Internal/ADJUserDefaults.h b/Adjust/Internal/ADJUserDefaults.h
@@ -37,13 +37,10 @@
 + (void)removeCoppaCompliance;
 
 + (void)saveDeeplinkUrl:(NSURL *)deeplink
-            referrerUrl:(NSURL *)referrer
               clickTime:(NSDate *)clickTime;
 
 + (NSURL *)getDeeplinkUrl;
 
-+ (NSURL *)getDeeplinkReferrerUrl;
-
 + (NSDate *)getDeeplinkClickTime;
 
 + (void)removeDeeplink;

diff --git a/Adjust/Internal/ADJUserDefaults.m b/Adjust/Internal/ADJUserDefaults.m
@@ -14,15 +14,13 @@
 static NSString * const PREFS_KEY_INSTALL_TRACKED = @"adj_install_tracked";
 static NSString * const PREFS_KEY_COPPA_COMPLIANCE = @"adj_coppa_compliance";
 static NSString * const PREFS_KEY_DEEPLINK_URL = @"adj_deeplink_url";
-static NSString * const PREFS_KEY_DEEPLINK_REFERRER_URL = @"adj_deeplink_referrer_url";
 static NSString * const PREFS_KEY_DEEPLINK_CLICK_TIME = @"adj_deeplink_click_time";
 static NSString * const PREFS_KEY_ADSERVICES_TRACKED = @"adj_adservices_tracked";
 static NSString * const PREFS_KEY_SKAD_REGISTER_CALL_TIME = @"adj_skad_register_call_time";
 static NSString * const PREFS_KEY_LINK_ME_CHECKED = @"adj_link_me_checked";
 static NSString * const PREFS_KEY_DEEPLINK_URL_CACHED = @"adj_deeplink_url_cached";
 static NSString * const PREFS_KEY_ATT_WAITING_REMAINING_SECONDS = @"adj_att_waiting_remaining_seconds";
 static NSString * const PREFS_KEY_CONTROL_PARAMS = @"adj_control_params";
-static NSString * const PREFS_KEY_DEEPLINK_REFERRER_URL_CACHED = @"adj_deeplink_referrer_url_cached";
 
 @implementation ADJUserDefaults
 
@@ -83,28 +81,21 @@ + (void)removeCoppaCompliance {
 }
 
 + (void)saveDeeplinkUrl:(NSURL *)deeplink
-            referrerUrl:(NSURL *)referrer
               clickTime:(NSDate *)clickTime {
     [[NSUserDefaults standardUserDefaults] setURL:deeplink forKey:PREFS_KEY_DEEPLINK_URL];
-    [[NSUserDefaults standardUserDefaults] setURL:referrer forKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
     [[NSUserDefaults standardUserDefaults] setObject:clickTime forKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
 }
 
 + (NSURL *)getDeeplinkUrl {
     return [[NSUserDefaults standardUserDefaults] URLForKey:PREFS_KEY_DEEPLINK_URL];
 }
 
-+ (NSURL *)getDeeplinkReferrerUrl {
-    return [[NSUserDefaults standardUserDefaults] URLForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
-}
-
 + (NSDate *)getDeeplinkClickTime {
     return [[NSUserDefaults standardUserDefaults] objectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
 }
 
 + (void)removeDeeplink {
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_URL];
-    [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
 }
 
@@ -173,7 +164,6 @@ + (void)clearAdjustStuff {
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_COPPA_COMPLIANCE];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_GDPR_FORGET_ME];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_URL];
-    [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_ADSERVICES_TRACKED];
     [[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_SKAD_REGISTER_CALL_TIME];

diff --git a/AdjustTests/AdjustTestApp/AdjustTestApp/ATAAdjustCommandExecutor.m b/AdjustTests/AdjustTestApp/AdjustTestApp/ATAAdjustCommandExecutor.m
@@ -580,12 +580,8 @@ - (void)setPushToken:(NSDictionary *)parameters {
 
 - (void)openDeeplink:(NSDictionary *)parameters {
     NSString *deeplinkS = [parameters objectForKey:@"deeplink"][0];
-    NSString *referrerS = [parameters objectForKey:@"referrer"][0];
     NSURL *deeplink = [NSURL URLWithString:deeplinkS];
-    NSURL *referrer = [NSURL URLWithString:referrerS];
-    ADJDeeplink *adjustDeeplink = [[ADJDeeplink alloc] initWithDeeplink:deeplink];
-    adjustDeeplink.referrer = referrer;
-    [Adjust processDeeplink:adjustDeeplink];
+    [Adjust processDeeplink:[[ADJDeeplink alloc] initWithDeeplink:deeplink]];
 }
 
 - (void)gdprForgetMe:(NSDictionary *)parameters {