Add environment variable ROS_PACKAGE_PATH to paths searched for messages #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GE_PATH to paths searched for messages
|
@adnanademovic are you accepting contributions to this repository? |
|
Looks good, thanks! I've been on a bit of a hiatus, contributions are appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ROS_PACKAGE_PATH as a source for paths where messages will be searched for. This is the variable used by tools like rospack which are in turn used by
rosmsgandrossrvfor finding packages on the system.I noticed that this block of code is duplicated in a couple places and I think it makes sense to try to de-duplicate it, but I'll leave that to another issue/merge request.
This seeks to close issue #166