Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2619] Fixed Non-deterministic behavior of HashMap that might fail tests using NextGenDMImageURIBuilder #2628

Conversation

SaaiVenkat
Copy link
Contributor

Q A
Fixed Issues? Fixes #2619
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Not Applicable
Documentation Provided No
Any Dependency Changes? No
License Apache License, Version 2.0
  • As mentioned in the 'Proposed Solution' section of the issue #2619, the implementation of params Map is changed from HashMap to LinkedHashMap.
  • This ensures that the order of parameters in the URI will be maintained in the order of insertion, which remains constant over time.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SaaiVenkat SaaiVenkat changed the title Changed HashMap to LinkedHashMap to maintain params order while gener… [2619] Fixed Non-deterministic behavior of HashMap that might fail tests Nov 29, 2023
@SaaiVenkat SaaiVenkat changed the title [2619] Fixed Non-deterministic behavior of HashMap that might fail tests [2619] Fixed Non-deterministic behavior of HashMap that might fail tests in NextGenDMImageURIBuilder Nov 29, 2023
@SaaiVenkat SaaiVenkat changed the title [2619] Fixed Non-deterministic behavior of HashMap that might fail tests in NextGenDMImageURIBuilder [2619] Fixed Non-deterministic behavior of HashMap that might fail tests Nov 29, 2023
@SaaiVenkat SaaiVenkat changed the title [2619] Fixed Non-deterministic behavior of HashMap that might fail tests [2619] Fixed Non-deterministic behavior of HashMap that might fail tests using NextGenDMImageURIBuilder Nov 29, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14e70e3) 87.34% compared to head (cd94839) 87.34%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2628   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7080     7080           
  Branches       1073     1073           
=========================================
  Hits           6184     6184           
  Misses          359      359           
  Partials        537      537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladbailescu vladbailescu merged commit 1a2ec13 into adobe:main Dec 27, 2023
7 checks passed
@LSantha LSantha added this to the 2.24.0 milestone Feb 14, 2024
@SaaiVenkat SaaiVenkat deleted the improvement/fix-flaky-NextgenDMImageURIBuilderTest branch October 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NextGenDMImageURIBuilder] Non-deterministic behavior of HashMap might fail tests
3 participants