PLATIR-45069: Add theme overrides for Floating button AEP Presentables #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently UIService components are built to inherit the current activity's theme to maintain the app's styling. While this works for most cases, background is one the items where inheriting the parent theme as is does not work well, as this property applies to the view background for all views within an activity - covering the draggable floating button area, covering the in-app message background window etc.
This PR solves the problem by creating a copy of the current app theme and overriding specific attributes with values that are needed. This override is applied only for FloatingButton presentables for now to limit the scope. We can look into adding this approach (simply invoking
getThemedContext()
) to other presentables if there are more requests.Related Issue
PLATIR-45069
Motivation and Context
How Has This Been Tested?
android:background
value for thetestapp
(tested bothTheme.AppCompat.*
andandroid:Theme.Material
) and ensure that the floating button still shows up with a transparent background draggable area.Screenshots (if appropriate):
Types of changes
Checklist: