Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup AndroidManifest.xml #741

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Cleanup AndroidManifest.xml #741

merged 3 commits into from
Feb 10, 2025

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Feb 10, 2025

  • Set android:exported=false for the ExtensionDiscovery service.
  • Add license headers.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.96%. Comparing base (61f73fc) to head (0d6236b).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...a/com/adobe/marketing/mobile/ExtensionDiscovery.kt 0.00% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (65.96%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (61f73fc) and HEAD (0d6236b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (61f73fc) HEAD (0d6236b)
unit-tests 3 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #741       +/-   ##
=============================================
- Coverage     85.26%   65.96%   -19.30%     
- Complexity      592     2017     +1425     
=============================================
  Files            37      216      +179     
  Lines          2293    10643     +8350     
  Branches        337     1384     +1047     
=============================================
+ Hits           1955     7020     +5065     
- Misses          193     3072     +2879     
- Partials        145      551      +406     
Flag Coverage Δ
android-functional-tests 27.62% <0.00%> (?)
android-unit-tests 61.40% <0.00%> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...a/com/adobe/marketing/mobile/ExtensionDiscovery.kt 4.35% <0.00%> (ø)

... and 193 files with indirect coverage changes

@praveek praveek merged commit 384a371 into adobe:dev Feb 10, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants