-fix sql delete statement and improve handling of unexpected database errors #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PravinPK
reviewed
Jul 26, 2021
| self?.processNextHit() | ||
| } else { | ||
| // deleting the hit from the database failed | ||
| // need to delete the database to try and recover |
There was a problem hiding this comment.
can we leave a warning log in the else part here?
There was a problem hiding this comment.
@sbenedicadb should we create a Github issue for it, then we can fix it in a future version?
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## dev-v3.2.3 #669 +/- ##
==============================================
- Coverage 85.34% 85.30% -0.05%
==============================================
Files 105 105
Lines 4633 4639 +6
==============================================
+ Hits 3954 3957 +3
- Misses 679 682 +3 |
PravinPK
approved these changes
Jul 26, 2021
yangyansong-adbe
added a commit
that referenced
this pull request
Jul 28, 2021
* Update Package.swift (#664) * -fix sql delete statement and improve handling of unexpected database errors (#669) * -fix sql delete statement and improve handling of unexpected database errors * -add a log warning explaining sdk behavior * Add isTaskScheduled flag to avoid duplicate tasks (#674) * update version (3.2.2 - 3.2.3) (#676)
yangyansong-adbe
added a commit
that referenced
this pull request
Jul 29, 2021
* Update Package.swift (#664) * -fix sql delete statement and improve handling of unexpected database errors (#669) * -fix sql delete statement and improve handling of unexpected database errors * -add a log warning explaining sdk behavior * Add isTaskScheduled flag to avoid duplicate tasks (#674) * update version (3.2.2 - 3.2.3) (#676)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.