Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SITES-2874 Accessibility) - Visual list is not marked up as list. #320

Closed
wants to merge 14 commits into from
Closed

fix(SITES-2874 Accessibility) - Visual list is not marked up as list. #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
12080c4
added roles list and listitem for the required elements
StoianLucian Oct 25, 2023
031a434
removed whitespace
StoianLucian Oct 25, 2023
eabed44
corrected listItem role
StoianLucian Oct 26, 2023
f173bc4
add role list to parent
StoianLucian Oct 26, 2023
89fd12f
restored initial added code
StoianLucian Oct 26, 2023
2773810
Update AnchorListItem.js
Pareesh Mar 20, 2024
bd3c12a
added role list
StoianLucian Mar 27, 2024
9385ee0
added space
StoianLucian Mar 27, 2024
2520aaf
added space
StoianLucian Mar 27, 2024
52c5adf
added role list
StoianLucian Mar 27, 2024
2b4bce5
added role list
StoianLucian Mar 27, 2024
1120396
added role list
StoianLucian Mar 27, 2024
972c163
added role listitem
StoianLucian Mar 27, 2024
a93bdfe
added roles
StoianLucian Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions coral-base-list/src/scripts/BaseList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ const BaseList = (superClass) => class extends superClass {
super.render();

this.classList.add(CLASSNAME);
this.setAttribute('role', 'list');

// Default reflected attributes
if (!this._interaction) {
Expand Down
1 change: 1 addition & 0 deletions coral-base-list/src/scripts/BaseListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ const BaseListItem = (superClass) => class extends BaseLabellable(superClass) {
// The attribute that makes different types of list items co-exist
// This is also used for event delegation
this.setAttribute('coral-list-item', '');
this.setAttribute('role', 'listitem');

// Fetch or create the content content zone element
const content = this._elements.content;
Expand Down
1 change: 0 additions & 1 deletion coral-component-list/src/scripts/AnchorList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ const AnchorList = Decorator(class extends BaseList(BaseComponent(HTMLElement))
render() {
super.render();

this.classList.add(CLASSNAME);
}
});

Expand Down
Loading