Fix: pipes + unpiping unquotes (Fixes #51)

adobe · Jun 14, 2023 · 4f24125 · 4f24125 · elliottneilclark · Jun 14, 2023
1 parent d9f1712
commit 4f24125
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## main
 
+### Fixes
+
+* don't unpipe single-piped `unquote` expressions (h/t @elliottneilclark)
+
 ## v0.7.12
 
 ### Fixes

diff --git a/lib/style/pipes.ex b/lib/style/pipes.ex
@@ -38,6 +38,10 @@ defmodule Styler.Style.Pipes do
           {{:|>, _, [{:|>, _, _}, _]}, _} = chain_zipper ->
             {:cont, find_pipe_start(chain_zipper), ctx}
 
+          # don't un-pipe into unquotes, as some expressions are only valid as pipes
+          {{:|>, _, [_, {:unquote, _, [_]}]}, _} = single_pipe_unquote_zipper ->
+            {:cont, single_pipe_unquote_zipper, ctx}
+
           {{:|>, _, [lhs, rhs]}, _} = single_pipe_zipper ->
             {_, meta, _} = lhs
             lhs = Style.set_line(lhs, meta[:line])

diff --git a/test/style/pipes_test.exs b/test/style/pipes_test.exs
@@ -246,6 +246,10 @@ defmodule Styler.Style.PipesTest do
   end
 
   describe "single pipe issues" do
+    test "allows unquote single pipes" do
+      assert_style("foo |> unquote(bar)")
+    end
+
     test "fixes simple single pipes" do
       assert_style("b(a) |> c()", "a |> b() |> c()")
       assert_style("a |> f()", "f(a)")