Parameter setup bugfixes #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryBaranovskiy or @GarthDB sorry for the 🏓 ping but I do not have merge & release rights. The first fix is straightforward. The second fix is a bit of a workaround, but still succeeds in loading the example URLs filed in the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses two issues encountered when loading themes via URL.
The first issue was due to lightness interpreted as
undefined. The second was solved by ignoring the smoothing setting for the first color scale, then setting it downstream if the color space was OKLAB or OKLCH.Motivation
Want users to be able to use the site with these parameters setup.
Screenshots
To-do list