Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor donut metric summary #344

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

marshallpete
Copy link
Member

Description

Refactor the donut API so that DonutSummary is its own component. In a future PR, I will break out ArcLabel into its own component.

Related Issue

#218
#180

Motivation and Context

This cleans up the API and also makes the summary optional

Stories

Donut > DonutSummary

Screenshots (if appropriate):

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marshallpete
Copy link
Member Author

This is a breaking change but it is on an alpha component so we are safe.

I'll update the docs when I finish up the productionization of donut.

Copy link

github-actions bot commented Jun 7, 2024

Copy link

sonarqubecloud bot commented Jun 7, 2024

Copy link

github-actions bot commented Jun 7, 2024

@marshallpete marshallpete linked an issue Jun 7, 2024 that may be closed by this pull request
@richiepreece richiepreece merged commit 6cfdb10 into main Jun 7, 2024
5 checks passed
@richiepreece richiepreece deleted the refactorDonutMetricSummary branch June 7, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Donut metric optional
2 participants