feat: update text anchor for segment labels #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-348 |
Abigail-Larsen
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the segment label anchor position. The anchor used to be the left or right side in between the label and the value. Now it is based on the quadrant. For example: If the segment label is in the top left, it's anchor is the bottom right.
Related Issue
#218
Screenshots (if appropriate):
It's subtle but notice how the spacing between the donut and the summary label is now more consistent (always 6px)
Was:
Is:
Story:
Donut > SegmentLabels
Types of changes
Checklist: