Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: camelcase for urls suggestions #655

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: camelcase for urls suggestions #655

wants to merge 3 commits into from

Conversation

AndreiAlexandruParaschiv
Copy link
Contributor

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv commented Feb 14, 2025 •
edited
Loading

  • Renaming urls_suggestions to urlsSuggestions

@AndreiAlexandruParaschiv
Copy link
Contributor Author

@solaris007 , @nitinja I remember seeing the broken-internal-links using camelCase format, whereas for sitemap and backlinks we are using urls_suggested instead of urlsSuggested - example : https://github.com/adobe/spacecat-api-service/blob/41ecc35e33523d78ede16db77ab3b2e8eb53d001/docs/openapi/schemas.yaml#L2329. For consistency, I opened this PR to rename it accordingly

@github-actions GitHub Actions
Copy link

This PR will trigger a patch release when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solaris007 solaris007 solaris007 approved these changes

@dzehnder dzehnder Awaiting requested review from dzehnder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreiAlexandruParaschiv @solaris007