Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce fetch config for site to use custom headers #585

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

dzehnder
Copy link
Contributor

@dzehnder dzehnder commented Feb 6, 2025

Introduce new fetchConfig to be able to add custom headers, like User-Agent, per site.

We need this as the fetch operation does not work for all sites with the same User-Agent.

@dzehnder dzehnder added the enhancement New feature or request label Feb 6, 2025
@dzehnder dzehnder self-assigned this Feb 6, 2025
Copy link
Member

@ekremney ekremney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

This PR will trigger a minor release when merged.

@dzehnder dzehnder merged commit 10a2892 into main Feb 17, 2025
7 checks passed
@dzehnder dzehnder deleted the feat-introduce-fetchConfig branch February 17, 2025 13:24
solaris007 pushed a commit that referenced this pull request Feb 17, 2025
# [@adobe/spacecat-shared-data-access-v2.4.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.3.1...@adobe/spacecat-shared-data-access-v2.4.0) (2025-02-17)

### Features

* introduce fetch config for site to use custom headers ([#585](#585)) ([10a2892](10a2892))
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

solaris007 pushed a commit that referenced this pull request Feb 17, 2025
# [@adobe/spacecat-shared-utils-v1.32.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.31.1...@adobe/spacecat-shared-utils-v1.32.0) (2025-02-17)

### Features

* introduce fetch config for site to use custom headers ([#585](#585)) ([10a2892](10a2892))
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants