-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Client to interact with Genvar APIs #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will trigger a minor release when merged. |
@dipratap please add a proper PR description detailing the change |
@solaris007 Added a description |
solaris007
reviewed
Feb 13, 2025
packages/spacecat-shared-gpt-client/src/clients/genvar-client.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-gpt-client/src/clients/genvar-client.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-gpt-client/src/clients/genvar-client.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-gpt-client/src/clients/genvar-client.js
Outdated
Show resolved
Hide resolved
solaris007
approved these changes
Feb 13, 2025
solaris007
pushed a commit
that referenced
this pull request
Feb 17, 2025
# [@adobe/spacecat-shared-gpt-client-v1.5.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-gpt-client-v1.4.7...@adobe/spacecat-shared-gpt-client-v1.5.0) (2025-02-17) ### Features * add Client to interact with Genvar APIs ([#596](#596)) ([cd69beb](cd69beb))
🎉 This PR is included in version @adobe/spacecat-shared-gpt-client-v1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.corp.adobe.com/browse/SITES-26415
Related PR: adobe/spacecat-audit-worker#608
Change description: Adding a Genvar client that will interact with Genvar APIs. The client exposes a generate suggestions method which takes the request body and request path as inputs. It first submit the job to Genvar, and then polls its status at regular intervals until it receives a terminal status.
One of the usages: Used by metatags audit handler to generate AI suggestions for meta-tags.