Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sp-button): bumped button css version to 14 and rebuilt css #5061

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caseyisonit
Copy link
Collaborator

@caseyisonit caseyisonit commented Feb 3, 2025

Description

This PR bumps the sb-button CSS version to 14.0.0 and rebuilds the CSS.

This was an attempt to address three design QA bugs for the Spectrum 2 theme. It resolves one of the issues. Once the CSS team gets the fixes in, a follow-up PR will need to follow.

Related issue(s)

  • SWC-496

Motivation and context

Ensure S2 theme looks accurate and CSS is up to date

How has this been tested?

  • Secondary Outline Button

    1. From the storybook preview link
    2. Select Spectrum 2 theme and Light Mode
    3. Button > Secondary > Outline > Default
    4. Inspect the border color
    5. Should be gray-200
  • Black Outline Button — THIS ONE FAILS

    1. From the storybook preview link
    2. Select Spectrum 2 theme and Light Mode
    3. Button > Black > Outline > Default
    4. Inspect the border color
    5. Should be transparent-black-800
  • White Outline Button — THIS ONE FAILS

    1. From the storybook preview link
    2. Select Spectrum 2 theme and Light Mode
    3. Button > White > Outline > Default
    4. Inspect the border color
    5. Should be transparent-white-800

Screenshots (if appropriate)

🟢 Screenshot 2025-02-03 at 3 04 47 PM


🔴 Screenshot 2025-02-03 at 3 06 01 PM


🔴 Screenshot 2025-02-03 at 3 06 49 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@caseyisonit caseyisonit requested a review from a team as a code owner February 3, 2025 22:25
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 0cd5647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Feb 3, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Feb 3, 2025

Tachometer results

Currently, no packages are changed by this PR...

Copy link

github-actions bot commented Feb 3, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.285 kB 236.526 kB 234.624 kB 🏆
Scripts 61.013 kB 54.501 kB 54.02 kB 🏆
Stylesheet 53.356 kB 47.60 kB 46.124 kB 🏆
Document 6.236 kB 5.459 kB 🏆 5.507 kB
Font 126.835 kB 126.615 kB 🏆 126.623 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build 13163567008

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.189%

Totals Coverage Status
Change from base Build 13141300428: -0.003%
Covered Lines: 33099
Relevant Lines: 33528

💛 - Coveralls

@rubencarvalho
Copy link
Collaborator

rubencarvalho commented Feb 4, 2025

Unfortunately, there is more foundational work needed to pick up the most recent CSS changes. Seems to be happening here: #5062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants