Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some balanced GC modes with AArch64 OpenJ9 #676

Closed
wants to merge 1 commit into from

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 25, 2025

This commit disables some balanced GC modes with AArch64 OpenJ9, reverting the changes in #530.

This commit disables some balanced GC modes with AArch64 OpenJ9,
reverting the changes in adoptium#530.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k
Copy link
Contributor Author

knn-k commented Feb 25, 2025

This is a workaround for eclipse-openj9/openj9#21178

@pshipton pshipton requested a review from llxia February 27, 2025 00:17
@llxia
Copy link
Contributor

llxia commented Feb 27, 2025

How many tests are affected? In general, temporary disable should be set in playlist.xml, not in ottawa.csv file. Also, by changing ottawa.csv, we will not be able to run these tests without changing the code.

For DaaLoadTest_daa1_special_5m, update https://github.com/adoptium/aqa-tests/blob/3208a395941bca5856b37977b067205f1da990ab/system/daaLoadTest/playlist.xml#L174 with <disable> tag.

<disable> example, see https://github.com/adoptium/aqa-tests/blob/master/system/lambdaLoadTest/playlist.xml#L185-L189

disabled test can be executed by setting TARGET=disabled.<test name>

Documentation: https://github.com/eclipse-openj9/openj9/blob/master/test/docs/OpenJ9TestUserGuide.md#manually-exclude-a-test-target

@pshipton
Copy link
Contributor

pshipton commented Feb 27, 2025

This is what failed. If there are others with -Xgcpolicy:balanced it seems they could also fail intermittently.

DaaLoadTest_daa1_special_5m_12
DaaLoadTest_daa1_special_5m_16
DaaLoadTest_daa1_special_5m_18

DaaLoadTest_daa2_special_5m_12
DaaLoadTest_daa2_special_5m_13
DaaLoadTest_daa2_special_5m_16
DaaLoadTest_daa2_special_5m_17
DaaLoadTest_daa2_special_5m_18

DaaLoadTest_all_special_5m_12
DaaLoadTest_all_special_5m_13
DaaLoadTest_all_special_5m_16
DaaLoadTest_all_special_5m_17

@knn-k
Copy link
Contributor Author

knn-k commented Feb 27, 2025

Thank you, @llxia and @pshipton.
I am going to run a test job with a commit in https://github.com/knn-k/aqa-tests/tree/issue21178.
I will open a pull request in aqa-tests with it when the job finishes as expected.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 27, 2025

I opened adoptium/aqa-tests#5989 that changes the playlist.xml for DaaLoadTest.

@knn-k knn-k closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants