Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve blog template #711

Merged
merged 3 commits into from
Jan 22, 2025
Merged

improve blog template #711

merged 3 commits into from
Jan 22, 2025

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 21, 2025

Description of change

This is far from a complete implementation but I figured we should make the changes bit-by-bit.

Also adds the new news homepage https://deploy-preview-711--adoptium-rewrite.netlify.app/news

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit 63785e8
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/679111f47c72d100084af142
😎 Deploy Preview https://deploy-preview-711--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 98.41897% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.36%. Comparing base (27c6b6a) to head (63785e8).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...onents/News/RelatedArticles/RelatedArticleCard.tsx 88.00% 3 Missing ⚠️
src/components/News/NewsCardList/index.tsx 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   82.41%   82.36%   -0.06%     
==========================================
  Files         140      145       +5     
  Lines       10756    10782      +26     
  Branches      825      829       +4     
==========================================
+ Hits         8865     8881      +16     
- Misses       1891     1901      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karianna
Copy link
Contributor

@gdams - I wasn't able to get to the blog in the deploy netlify

@gdams
Copy link
Member Author

gdams commented Jan 22, 2025

@gdams - I wasn't able to get to the blog in the deploy netlify

sorry I should have provided a link: https://deploy-preview-711--adoptium-rewrite.netlify.app/en-GB/blog/2024/01/slsabuild3-temurin/

Copy link
Contributor

@Jexsie Jexsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see Codecov is complaining, are we ignoring this for now @gdams ?

@gdams
Copy link
Member Author

gdams commented Jan 22, 2025

LGTM. I see Codecov is complaining, are we ignoring this for now @gdams ?

yeah we'll follow up with that later

@karianna karianna merged commit 0b8a546 into adoptium:main Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants