-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve blog template #711
Conversation
✅ Deploy Preview for adoptium-rewrite ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 82.41% 82.36% -0.06%
==========================================
Files 140 145 +5
Lines 10756 10782 +26
Branches 825 829 +4
==========================================
+ Hits 8865 8881 +16
- Misses 1891 1901 +10 ☔ View full report in Codecov by Sentry. |
@gdams - I wasn't able to get to the blog in the deploy netlify |
sorry I should have provided a link: https://deploy-preview-711--adoptium-rewrite.netlify.app/en-GB/blog/2024/01/slsabuild3-temurin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I see Codecov is complaining, are we ignoring this for now @gdams ?
yeah we'll follow up with that later |
Description of change
This is far from a complete implementation but I figured we should make the changes bit-by-bit.
Also adds the new news homepage https://deploy-preview-711--adoptium-rewrite.netlify.app/news
Checklist
npm test
passes