Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-765] Fix rendering tab based on url #773

Merged

Conversation

xavierfacq
Copy link
Member

Description of change

This PR is to fix the problem Tab update depending of version in url params.
I have renamed the "active" useState to "activeVersionSelectorTab" for a better understanding.

Checklist

  • npm test passes

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit eed36ae
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/67a62291243d0a00078fac3e
😎 Deploy Preview https://deploy-preview-773--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (7982074) to head (eed36ae).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Temurin/Tabs/index.tsx 42.85% 8 Missing ⚠️
src/components/Temurin/VersionSelector/index.tsx 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
+ Coverage   80.07%   80.10%   +0.02%     
==========================================
  Files         155      155              
  Lines       11664    11666       +2     
  Branches      865      867       +2     
==========================================
+ Hits         9340     9345       +5     
+ Misses       2324     2321       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq xavierfacq marked this pull request as ready for review February 7, 2025 10:41
@xavierfacq xavierfacq requested a review from gdams February 7, 2025 10:41
@gdams gdams linked an issue Feb 7, 2025 that may be closed by this pull request
@gdams
Copy link
Member

gdams commented Feb 7, 2025

This is looking better but if I go to https://deploy-preview-773--adoptium-rewrite.netlify.app/en-GB/temurin/releases/?os=any&arch=any&version=20 (e.g a non-LTS version) it's now redirecting to JDK21. Instead it should serve up JDK20 binaries and open the All Versions tab with the version selected

@xavierfacq
Copy link
Member Author

This is looking better but if I go to https://deploy-preview-773--adoptium-rewrite.netlify.app/en-GB/temurin/releases/?os=any&arch=any&version=20 (e.g a non-LTS version) it's now redirecting to JDK21. Instead it should serve up JDK20 binaries and open the All Versions tab with the version selected

After the deploy it should be ok.

@gdams gdams merged commit f150d8f into adoptium:main Feb 7, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest releases not rendering version tab based on URL
2 participants