-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue-765] Fix rendering tab based on url #773
[issue-765] Fix rendering tab based on url #773
Conversation
✅ Deploy Preview for adoptium-rewrite ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
+ Coverage 80.07% 80.10% +0.02%
==========================================
Files 155 155
Lines 11664 11666 +2
Branches 865 867 +2
==========================================
+ Hits 9340 9345 +5
+ Misses 2324 2321 -3 ☔ View full report in Codecov by Sentry. |
This is looking better but if I go to https://deploy-preview-773--adoptium-rewrite.netlify.app/en-GB/temurin/releases/?os=any&arch=any&version=20 (e.g a non-LTS version) it's now redirecting to JDK21. Instead it should serve up JDK20 binaries and open the All Versions tab with the version selected |
After the deploy it should be ok. |
Description of change
This PR is to fix the problem Tab update depending of version in url params.
I have renamed the "active" useState to "activeVersionSelectorTab" for a better understanding.
Checklist
npm test
passes