Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download page: add links to nav icons #737

Merged
merged 1 commit into from
Jan 29, 2025
Merged

download page: add links to nav icons #737

merged 1 commit into from
Jan 29, 2025

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 28, 2025

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit b40e66f
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/6798d898b4a14a00080b32b8
😎 Deploy Preview https://deploy-preview-737--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (eaf9190) to head (b40e66f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Temurin/ButtonContent/index.tsx 64.28% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   82.36%   82.48%   +0.12%     
==========================================
  Files         145      145              
  Lines       10780    10786       +6     
  Branches      829      829              
==========================================
+ Hits         8879     8897      +18     
+ Misses       1901     1889      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdams gdams merged commit 843d683 into adoptium:main Jan 29, 2025
11 of 12 checks passed
@gdams gdams deleted the release branch January 29, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants