Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/adoptium 666 bookmark support #2107

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

xavierfacq
Copy link
Member

Description of change

Fix issue #666 "Bookmark Support"

When going to https://adoptium.net/temurin/releases/

  • It's now possible to select values from dropdowns and they are added to the URL.
  • A bookmarked link is now supported and all filters are applied to the query.
  • Results are ordered from newest to oldest (release_date DESC).
  • Dropdowns are sorted alphabetically (more intuitive).

Supported parameters are:

  • os=[windows, linux...] default 'any'
  • arch=[x64, x86...] default 'any'
  • package=[jdk, jre] default 'any' or 'jdk' in marketplace
  • version=[19, 18...] default is 'lastest'
  • variant=[openjdk11,...]

Function setURLParam() has been improved with:

  • it add a new parameter without loosing existing ones (append mode)
  • ability to "remove" a parameter by passing 'undefined' as value

e.g. http://localhost:8000/temurin/releases/?os=linux&arch=x64&package=jdk

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9ad7638
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64dd20bc65f7a500082d1d98
😎 Deploy Preview https://deploy-preview-2107--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2107 (9ad7638) into main (9362c64) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 95.65%.

@@           Coverage Diff           @@
##             main    #2107   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          85       85           
  Lines        6199     6245   +46     
  Branches      509      519   +10     
=======================================
+ Hits         6147     6193   +46     
  Misses         52       52           
Files Changed Coverage Δ
src/components/DownloadDropdowns/index.tsx 92.42% <93.18%> (+0.99%) ⬆️
src/components/TemurinDownloadTable/index.tsx 100.00% <100.00%> (ø)
src/util/setURLParam.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gdams gdams linked an issue Aug 16, 2023 that may be closed by this pull request
@xavierfacq xavierfacq marked this pull request as ready for review August 16, 2023 21:07
@karianna karianna merged commit eab0792 into adoptium:main Aug 17, 2023
10 of 11 checks passed
@gdams gdams mentioned this pull request Aug 24, 2023
4 tasks
@xavierfacq xavierfacq deleted the fix/adoptium-666_Bookmark_Support branch September 7, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark Support
3 participants