Bookmark Support in release page #2001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 99.15% 99.16%
=======================================
Files 85 85
Lines 6181 6192 +11
Branches 507 509 +2
=======================================
+ Hits 6129 6140 +11
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gdams
reviewed
Jul 17, 2023
| React.useEffect(() => { | ||
| if (!initialLoad) { | ||
| setInitialLoad(true) | ||
| window.history.replaceState(null, null, '/temurin/releases/?os=win&arch=x64&package=jdk') |
There was a problem hiding this comment.
We should not be hardcoding to windows. Can you not set the default to show all binaries?
|
@Ndacyayisenga-droid what is the state on that PR? |
|
I think this was superseded by #2107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmark Support in release page
Fixes #666
cc @hendrikebbers @gdams
Checklist
npm testpasses