Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support page to reflect July-release information #2065

Merged

Conversation

adamfarley
Copy link
Contributor

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 2d8f766
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64d3825fca5d660008ebdc63
😎 Deploy Preview https://deploy-preview-2065--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2065 (2d8f766) into main (1bea8b8) will increase coverage by 0.00%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2065   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          85       85           
  Lines        6181     6188    +7     
  Branches      507      508    +1     
=======================================
+ Hits         6129     6136    +7     
  Misses         52       52           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a little bit strange having "EOSL" for JDK20 while still having "End of Availability" in the future. Maybe we should adjust the meanings of those columns, but that's not necessarily for this issue, so I'm approving.

content/asciidoc-pages/support/index.adoc Outdated Show resolved Hide resolved
content/asciidoc-pages/support/index.adoc Outdated Show resolved Hide resolved
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: Not approving as the date for the next releases is incorrect :-)

@karianna karianna merged commit f5bcfcd into adoptium:main Aug 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants