Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial content for Scope of AQAvit blog #2741

Merged
merged 13 commits into from
May 15, 2024
Merged

Conversation

smlambert
Copy link
Contributor

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 6ff5c0e
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6644d29b0aac4700089ff869
😎 Deploy Preview https://deploy-preview-2741--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Shelley Lambert <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (0cb7af3) to head (6ff5c0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2741   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          89       89           
  Lines        6881     6881           
  Branches      605      605           
=======================================
  Hits         6842     6842           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member

@smlambert This PR is not merge, Is it an oversight ?

Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
@smlambert
Copy link
Contributor Author

It was missing some links and pictures, but is now ready to review a final time and merge.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a style thing as much as anything but this post reads as being in the passive voice as opposed to an active voice. For example:

Since AQAvit has developed both a consistent and open approach to measuring quality and a useful set of tools to benefit any JDK distributor, it has rapidly become the de facto standard by which companies can measure whether they trust the quality of the distribution they have selected to use

Could be changed to something like:

AQAvit has rapidly become the de facto standard by which companies can measure whether they trust the quality of the OpenJDK distribution they are selecting. This trust is earned because AQAvit has developed a consistent and open approach to measuring quality, as well providing an open toolset that any JDK distributor can use to demonstrate that they meet the AQAvit quality bar.

Something like that. Again, just a style thing but happy to make suggested edits if that's desirable :-).

content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edits, please take or leave as you see fit!

content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
content/blog/aqavit-scope/index.md Outdated Show resolved Hide resolved
@smlambert smlambert merged commit 700702e into adoptium:main May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants