-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial content for Scope of AQAvit blog #2741
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Shelley Lambert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 89 89
Lines 6881 6881
Branches 605 605
=======================================
Hits 6842 6842
Misses 39 39 ☔ View full report in Codecov by Sentry. |
@smlambert This PR is not merge, Is it an oversight ? |
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
It was missing some links and pictures, but is now ready to review a final time and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a style thing as much as anything but this post reads as being in the passive voice as opposed to an active voice. For example:
Since AQAvit has developed both a consistent and open approach to measuring quality and a useful set of tools to benefit any JDK distributor, it has rapidly become the de facto standard by which companies can measure whether they trust the quality of the distribution they have selected to use
Could be changed to something like:
AQAvit has rapidly become the de facto standard by which companies can measure whether they trust the quality of the OpenJDK distribution they are selecting. This trust is earned because AQAvit has developed a consistent and open approach to measuring quality, as well providing an open toolset that any JDK distributor can use to demonstrate that they meet the AQAvit quality bar.
Something like that. Again, just a style thing but happy to make suggested edits if that's desirable :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested edits, please take or leave as you see fit!
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Description of change
Checklist
npm test
passes