Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: External audit summary #2919

Merged
merged 10 commits into from
Jun 18, 2024
Merged

blog: External audit summary #2919

merged 10 commits into from
Jun 18, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 17, 2024

Description of change

Quick preview link: https://github.com/sxa/website-v2/blob/tob_audit_blog/content/blog/external_audit/index.md

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit e6ce9f9
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/667012c23684ab00087749f7
😎 Deploy Preview https://deploy-preview-2919--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (cacda7a) to head (e6ce9f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2919   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          90       90           
  Lines        6956     6956           
  Branches      608      608           
=======================================
  Hits         6917     6917           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member

Error is: Multiple consecutive blank lines
Seems to be the last blank line to remove.

Copy link
Member

@xavierfacq xavierfacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the last blank line

sxa added 2 commits June 17, 2024 11:28
Signed-off-by: Stewart X Addison <[email protected]>
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
content/blog/external_audit/index.md Outdated Show resolved Hide resolved
@sxa
Copy link
Member Author

sxa commented Jun 17, 2024

NOTE: This should not be made live until all other artifacts related to this are published as final copies - please leave to me to merge.

@sxa sxa merged commit fca6640 into adoptium:main Jun 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants