Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to use express.js v5 #945

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Upgrade to use express.js v5 #945

merged 1 commit into from
Dec 4, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Dec 4, 2024 •
edited
Loading

resolves: #941
fixes: #935

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium-trss canceled.

Name Link
🔨 Latest commit abd6028
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/675077298cfc730008eb9353

@llxia
Copy link
Contributor Author

llxia commented Dec 4, 2024

If an invalid ID is passed in, the server will return an error.

image

@llxia llxia requested a review from smlambert December 4, 2024 15:40
smlambert
smlambert approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @llxia !

@smlambert smlambert merged commit 6568dc3 into adoptium:master Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to use Express.js v5 Bug Report: TRSS API loops infinitely and returns null when GETting some fields
2 participants
@llxia @smlambert