Move SHA check function to TKG #5819
Conversation
|
Depends adoptium/TKG#651 |
sophia-guo
force-pushed
the
sha
branch
5 times, most recently
from
726a293 to
280ca14
Compare
sophia-guo
force-pushed
the
sha
branch
3 times, most recently
from
2145bef to
9564e08
Compare
get.sh
Outdated
| mkdir -p ../git-backup | ||
| mv .git ../git-backup | ||
| rm -rf * | ||
| mv ../git-backup .git |
There was a problem hiding this comment.
I do not think we should move .git file around. Can we move it into the subfolder? In this case, it should be functional.
There was a problem hiding this comment.
.git is not moved around. .git keeps in openj9/.git and all others under openj9 are removed. Same for all available vendors repo as vendor*/.git.
aqa-tests/functional may also have other vendor's test material. For example eclispe adoptium https://github.com/adoptium/temurin-build/tree/master/test/functional/ so it's not good to move .git to aqa-tests/functional
There was a problem hiding this comment.
To delete everything but .git, I would prefer to use git cmd https://stackoverflow.com/questions/22339837/linux-command-to-delete-all-files-except-git-folder
git rm -rf .
git clean -fxd
also, rm -rf * is dangerous to use.
There was a problem hiding this comment.
get.sh
Outdated
| @@ -746,7 +748,11 @@ getVendorTestMaterial() { | |||
| fi | |||
|
|
|||
| # clean up | |||
| rm -rf $dest | |||
| cd $dest | |||
| git rm -rf . | |||
There was a problem hiding this comment.
Can we add -q in git rm? Currently, it outputs a large amount of details.
00:01:50.652 Stage vendor_0/functional to /home/jenkins/workspace/Grinder/aqa-tests/functional
00:01:52.136 rm '.gitignore'
00:01:52.136 rm 'External_Test/Liberty_FAT_Playlist/build.xml'
00:01:52.136 rm 'External_Test/Liberty_FAT_Playlist/playlist.xml'
00:01:52.136 rm 'External_Test/Liberty_FAT_Playlist/runtest.pl'
00:01:52.136 rm 'External_Test/build.xml'
00:01:52.136 rm 'README.md'
00:01:52.136 rm 'TEST/.project'
...
There was a problem hiding this comment.
Do you want the quite rm for openj9 too? #5819 (comment). The commands here are exactly same for openj9 git remove as you required as before.
There was a problem hiding this comment.
Close #5818