Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tools/jpackage/share disabled by jdk_tools for non jdk17 #5891

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Enable tools/jpackage/share disabled by jdk_tools for non jdk17 #5891

merged 3 commits into from
Jan 23, 2025

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jan 21, 2025 •
edited
Loading

Exclude one failing test with alpine by linux-all under adoptium. So test is only excluded for adoptium on other linux platforms including alpine.

Close #3232

See tools/jpackage/share
related #5892
#5893
#5894

@sophia-guo
Enable tools/jpackage/share disabled by jdk_tools for non jdk17
09b9577 
Exclude one failing test with alpine by linux-all under adoptium. So
test is only excluded for adoptium on other linux platforms including
alpine.

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo self-assigned this Jan 21, 2025
@sophia-guo sophia-guo requested a review from smlambert January 21, 2025 21:38
@sophia-guo
Copy link
Contributor Author

Will not cherry-pick this for January's release. Need more runs before add to release.

@sophia-guo sophia-guo marked this pull request as draft January 21, 2025 21:45
@sophia-guo
Copy link
Contributor Author

Grinder jdk_tools targets with jdk23, jdk21 on apline aarch64 and jdk8,11,21,23 on apline x64. Exclude failing testcases based on the grinder run.

https://ci.adoptium.net/view/Test_grinder/job/Grinder/12420/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/12413/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/12412/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/12415/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/12416/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/12418/

@sophia-guo sophia-guo marked this pull request as ready for review January 22, 2025 03:18
@sophia-guo
update tracked issue
8bfd2a8 
Signed-off-by: Sophia Guo <[email protected]>
smlambert
smlambert reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many testcases does this end up excluding (how many are in jdk_tools target)?

@sophia-guo
Copy link
Contributor Author

How many testcases does this end up excluding (how many are in jdk_tools target)?

~450 - 600 testcases differs from jdk version and platforms. Newer version has more testcases. jdk23 ( 600) vs jdk8 ( 450).

@sophia-guo sophia-guo merged commit 7a5b676 into adoptium:master Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
2025 Adoptium Plan
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing openjdk17 alpine-linux jdk_tools tests
3 participants
@sophia-guo @smlambert @andrew-m-leonard