Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows docker fixes/workarounds #1099

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Aug 19, 2024

A few changes.
Follow up to adoptium/infrastructure#3702
Fixes adoptium/infrastructure#3713

  1. Docker SHA for the build image parameter is now set to {{.id}} since {{.RepoDigest}}' is not available in our case (possibly due to it being a local image, but a quick check suggests that the same problem doesn't look like it exists on Linux/s390x)
  2. Workspace is set "safe" via git config --global safe.directory otherwise it objects to it being owned by the user on the host and will not complete.

@sxa
Copy link
Member Author

sxa commented Aug 19, 2024

run tests

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa sxa force-pushed the windows_docker_support branch 6 times, most recently from 39abddb to 414076e Compare August 19, 2024 15:21
Signed-off-by: Stewart X Addison <[email protected]>
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@karianna karianna merged commit 9ebab10 into adoptium:master Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windocker: Merge or otherwise mitigate "dubious ownership" remediation
4 participants