Fix Dashboard shows incorrect download numbers #385

[xavierfacq]

This PR is to fix issue: Dashboard shows incorrect download numbers #385

What is in:

• In the /download page, the Github Downloads graph counts are now only based on the computation of returned assets.
• API returns inconsistency data (total = overall, sometimes with ga AND ea, sometimes only ga. (It's going to be fixed on the API), that's why I suggest to compute sums until it is fixed.
• Contains only results of available releases (JDK22 disappear)
• A warning is added under the graph to explain: *Includes only results with Type of release: General Availability(ga)

Screenshot

[netlify]

✅ Deploy Preview for eclipsefdn-adoptium-dash ready!

Name	Link
🔨 Latest commit	fef1c90
🔍 Latest deploy log	https://app.netlify.com/sites/eclipsefdn-adoptium-dash/deploys/653240566eb4ff00078d6701
😎 Deploy Preview	https://deploy-preview-389--eclipsefdn-adoptium-dash.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #389 (fef1c90) into main (6dab869) will increase coverage by 1.17%.
Report is 14 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   95.11%   96.29%   +1.17%     
==========================================
  Files           9        9              
  Lines         881      891      +10     
  Branches       66       75       +9     
==========================================
+ Hits          838      858      +20     
+ Misses         43       33      -10     

Files	Coverage Δ
src/Graph/ColumnDrilldown.tsx	98.13% <100.00%> (+4.96%)	⬆️
src/Graph/Download.tsx	100.00% <100.00%> (ø)
src/Graph/Trends.tsx	93.27% <100.00%> (-0.02%)	⬇️
src/api.tsx	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tellison]

Thanks for creating this fix @xavierfacq

I do think the chart is somewhat misleading at the top level (and probably always has been that way) as it contains all artifact types of a release including the SBOM and sources. I don't think that is clear from the title.

To me, this is exacerbated by adding the proposed text "Includes only results with Type of release: General Availability(ga)" and I would choose not to add that. If you feel strongly then maybe change the title from "Github Downloads" to "Github Release Downloads" or suchlike.

As a side note: it would be good to incorporate the package download (artifactory/Fastly) stats somehow but not sure how easy it would be to get those programmatically and reliably. These direct Github downloads are a small part of our actual distribution size.

[xavierfacq]

Ok, I remove the text in the bottom.
Just keep in mind that the drilldown graph DO NOT contains all Type of release (only ga).

[xavierfacq]

@tellison I have remove the text in the bottom ✔️

[tellison]

Ok, I remove the text in the bottom. Just keep in mind that the drilldown graph DO NOT contains all Type of release (only ga).

How about changing the title of the drill down bar chart to "Github Release Downloads" as suggested above?