-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinPB: Add Installation of VS2022 Redists #3774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the version # to a const at the top and reference that?
@karianna , I can envisage a situation whereby we might install multiple different Windows SDK versions for later JDKs. although this might be redundant when we move over to full windows devkit style builds... I'll make this change for now, and re-evaluate should the need arise. |
ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/MSVS_2022_REDIST/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/MSVS_2022_REDIST/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/MSVS_2022_REDIST/tasks/main.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks
Co-Authored-By: Stewart X Addison <[email protected]>
c03f9f0
to
6345cb9
Compare
/merge |
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
/approve |
1 similar comment
/approve |
Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Fixes #3772
Required as part of https://github.com/adoptium/temurin-build/pull/3981/files
Checklist
VPC Successful : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/1982/console