Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinPB: Add Installation of VS2022 Redists #3774

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #3772

Required as part of https://github.com/adoptium/temurin-build/pull/3981/files

Checklist

VPC Successful : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/1982/console

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract the version # to a const at the top and reference that?

@steelhead31
Copy link
Contributor Author

Can we extract the version # to a const at the top and reference that?

@karianna , I can envisage a situation whereby we might install multiple different Windows SDK versions for later JDKs. although this might be redundant when we move over to full windows devkit style builds... I'll make this change for now, and re-evaluate should the need arise.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@steelhead31
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@sxa
Copy link
Member

sxa commented Oct 10, 2024

/approve

1 similar comment
@andrew-m-leonard
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review October 10, 2024 10:18

Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 9ced499 into adoptium:master Oct 10, 2024
9 checks passed
@steelhead31 steelhead31 deleted the fix_issue_3772 branch October 10, 2024 10:28
sxa added a commit to sxa/infrastructure that referenced this pull request Oct 17, 2024
@sxa sxa added this to the 2024-10 (October) milestone Nov 1, 2024
mahdipub pushed a commit to mahdipub/infrastructure that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract vs2022_redist_14.40.33807_10.0.26100.0.zip onto Adoptium Windows nodes via ansible
4 participants