Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JDK17.0.9 Debian Version Numbers In The Changelog #768

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

steelhead31
Copy link
Contributor

Fix JDK17.0.9 Debian Version Numbers In The Changelog

Updated from 17.0.9.0+9 to 17.0.9.0.0+9

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this came across as part of this slack thread.

I'm ok to approve this but do we know if it will cause problems with people who already have the version which we had live? i.e. will this version with the extra .0 superceded the previous one? Since they're the same contents it shouldn't make too much of a difference but we would ideally want people to get the new one

@steelhead31
Copy link
Contributor Author

Obviously this came across as part of this slack thread.

I'm ok to approve this but do we know if it will cause problems with people who already have the version which we had live? i.e. will this version with the extra .0 superceded the previous one? Since they're the same contents it shouldn't make too much of a difference but we would ideally want people to get the new one

I've removed the erroneous ones from artifactory to prevent it impacting, it should still get updated on a future release, as 17.0.10 is later than either 17.0.9 version, Once the new artifacts are up, I'll post in the release channel advising the removal of the old, and replacement with the new, the identified failing update processes will work correctly with the new version.

@steelhead31
Copy link
Contributor Author

/merge

@github-actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@andrew-m-leonard
Copy link
Contributor

/approve

1 similar comment
@gdams
Copy link
Member

gdams commented Oct 30, 2023

/approve

@gdams gdams closed this Oct 30, 2023
@gdams gdams reopened this Oct 30, 2023
@github-actions github-actions bot dismissed their stale review October 30, 2023 13:59

Thank you @andrew-m-leonard and @gdams for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 0703e9f into adoptium:master Oct 30, 2023
17 checks passed
@steelhead31 steelhead31 deleted the fix_jdk1709_debian branch October 30, 2023 14:05
@steelhead31 steelhead31 self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants