Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version number is passed for Alpine & Debian installer builds #771

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

steelhead31
Copy link
Contributor

Update jenkinsfile so that version number is correctly passed through to the Alpine and Debian gradle builds, when ARCH parameter is set to ALL, this has been tested in a non-destructive fashion, in my test harness.. https://ci.adoptium.net/job/scott-fryer-adoptium-packages-linux-pipeline_new/237/ , https://ci.adoptium.net/job/scott-fryer-adoptium-packages-linux-pipeline_new/236 , https://ci.adoptium.net/job/scott-fryer-adoptium-packages-linux-pipeline_new/234 & https://ci.adoptium.net/job/scott-fryer-adoptium-packages-linux-pipeline_new/230

Fixes #764

@sophia-guo
Copy link
Contributor

I'm curious why VERSION is not accessible when doing parallel as it is an environment variable. Also interesting for debian and apline when running parallel with x86-64 and other platforms it consistently worked for x86-64. @steelhead31 do you have the idea?

I suspect that update these two lines https://github.com/adoptium/installer/blob/master/linux/Jenkinsfile#L324 and https://github.com/adoptium/installer/blob/master/linux/Jenkinsfile#L338 with -PPRODUCT_VERSION=${env.VERSION} probably also work.

@steelhead31
Copy link
Contributor Author

I'm curious why VERSION is not accessible when doing parallel as it is an environment variable. Also interesting for debian and apline when running parallel with x86-64 and other platforms it consistently worked for x86-64. @steelhead31 do you have the idea?

I suspect that update these two lines https://github.com/adoptium/installer/blob/master/linux/Jenkinsfile#L324 and https://github.com/adoptium/installer/blob/master/linux/Jenkinsfile#L338 with -PPRODUCT_VERSION=${env.VERSION} probably also work.

I don't think it is an environment variable within the contexts used by Debian & Alpine, it sets correctly on the first iteration of a loop, but then is subsequently unavailable to future iterations. This fix pushes the PRODUCT VERSION into a local context to pass onwards. The RHEL & SUSE steps do use environment variables for this reason I believe.

@karianna karianna merged commit c2de4d0 into adoptium:master Nov 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jenkins apline and debian build failures when using arch=all for arch != x86_64
4 participants