Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jdk8 installers for Jan 2024 release #804

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Update jdk8 installers for Jan 2024 release #804

merged 6 commits into from
Jan 26, 2024

Conversation

Haroon-Khel
Copy link
Contributor

Once arm32 is out this can be merged

github-actions[bot]
github-actions bot previously requested changes Jan 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@Haroon-Khel Haroon-Khel marked this pull request as ready for review January 25, 2024 10:29
@Haroon-Khel
Copy link
Contributor Author

/merge

@github-actions GitHub Actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@sxa
Copy link
Member

sxa commented Jan 25, 2024

/approve

@andrew-m-leonard
Copy link
Contributor

@Haroon-Khel ci failures due to aarch32 I think ?

@andrew-m-leonard
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review January 25, 2024 11:03

Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.

@Haroon-Khel
Copy link
Contributor Author

Seeing an error in the changelog

/var/tmp/rpm-tmp.25nVAQ: line 38: cd: jdk8u392-b08-aarch32-20231020-jre: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.25nVAQ (%prep)
    bogus date in %changelog: Thu Oct 25 2023 Eclipse Adoptium Package Maintainers <[email protected]> 8.0.392.0.0.8-1
    Bad exit status from /var/tmp/rpm-tmp.25nVAQ (%prep)

@jiekang
Copy link
Contributor

jiekang commented Jan 25, 2024 •
edited
Loading

Seeing an error in the changelog

/var/tmp/rpm-tmp.25nVAQ: line 38: cd: jdk8u392-b08-aarch32-20231020-jre: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.25nVAQ (%prep)
    bogus date in %changelog: Thu Oct 25 2023 Eclipse Adoptium Package Maintainers <[email protected]> 8.0.392.0.0.8-1
    Bad exit status from /var/tmp/rpm-tmp.25nVAQ (%prep)

Oct 25 2023 is a Wednesday :P

@Haroon-Khel
Copy link
Contributor Author

Oct 25 2023 is a Wednesday :P

Surprised it picked up on that. Thanks Jie

@Haroon-Khel
Copy link
Contributor Author

That fixed it

@Haroon-Khel Haroon-Khel merged commit ac328ea into adoptium:master Jan 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@sxa sxa sxa approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Haroon-Khel @sxa @andrew-m-leonard @jiekang @karianna