Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RPM spec & Debian versions to JDK21.0.2.0.0+13-2 #824

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #823

Bump the RPM spec, and the debian version numbers to allow an update to include the freetype library fix, made as part of #812

@jiekang
Copy link
Contributor

jiekang commented Feb 22, 2024

Seems fine to me. Would be nice to have someone with more Debian expertise to understand the implications of the change. I wonder if there is a debian tool similar to rpmdev-vercmp that you can just put in the two numbers and see what the result is.

E.g. with rpmdev-vercmp, you can check which version would be 'higher' between
21.0.2.0.0+13-2 & 21.0.2.0.0+13

As long as the -2 version is considered higher (by Debian), we should be good.

@steelhead31
Copy link
Contributor Author

Seems fine to me. Would be nice to have someone with more Debian expertise to understand the implications of the change. I wonder if there is a debian tool similar to rpmdev-vercmp that you can just put in the two numbers and see what the result is.

E.g. with rpmdev-vercmp, you can check which version would be 'higher' between 21.0.2.0.0+13-2 & 21.0.2.0.0+13

As long as the -2 version is considered higher (by Debian), we should be good.

dpkg does indeed have a similar concept..

dpkg --compare-versions 21.0.2.0.0+13 lt 21.0.2.0.0+13-2

The above command returns 0, ie 21.0.2.0.0+13 is less than 21.0.2.0.0+13-2  , were it to evaluate the opposite way then the return code would be 1.

@jiekang
Copy link
Contributor

jiekang commented Feb 22, 2024

Nice, thanks for checking. LGTM.

Copy link

@sebastianblesgen sebastianblesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Republish JDK21.0.2.0.0+13 Deb & RPMs With Freetype Library Fix
5 participants