Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs with the installer build processes #876

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

steelhead31
Copy link
Contributor

Improve handling of version specific distro lists, previous code was inconsistent and causing issues during uploads.

For Riscv upload function, ensure required parameters are passed to the new node.

@steelhead31 steelhead31 marked this pull request as draft April 26, 2024 14:01
@steelhead31 steelhead31 marked this pull request as ready for review April 26, 2024 14:07
@steelhead31 steelhead31 marked this pull request as draft April 26, 2024 14:12
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steelhead31
Copy link
Contributor Author

Holding on merge, as I think this may need a similar fix for the debian uploads  command becoming too long.

@steelhead31 steelhead31 force-pushed the sfr_installer_upload_fix branch 2 times, most recently from 682d15e to 816eb50 Compare April 26, 2024 18:29
@steelhead31 steelhead31 force-pushed the sfr_installer_upload_fix branch from e08dc0f to e235607 Compare April 26, 2024 19:22
@steelhead31 steelhead31 marked this pull request as ready for review April 26, 2024 19:56
@steelhead31 steelhead31 merged commit c6d7b64 into adoptium:master Apr 26, 2024
7 checks passed
@steelhead31 steelhead31 deleted the sfr_installer_upload_fix branch April 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants