-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several bugs with the installer build processes #876
Merged
steelhead31
merged 9 commits into
adoptium:master
from
steelhead31:sfr_installer_upload_fix
Apr 26, 2024
Merged
Fix several bugs with the installer build processes #876
steelhead31
merged 9 commits into
adoptium:master
from
steelhead31:sfr_installer_upload_fix
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Apr 26, 2024
…ad31/installer into sfr_installer_upload_fix
andrew-m-leonard
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Holding on merge, as I think this may need a similar fix for the debian uploads command becoming too long. |
steelhead31
force-pushed
the
sfr_installer_upload_fix
branch
2 times, most recently
from
April 26, 2024 18:29
682d15e
to
816eb50
Compare
steelhead31
force-pushed
the
sfr_installer_upload_fix
branch
from
April 26, 2024 19:22
e08dc0f
to
e235607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of version specific distro lists, previous code was inconsistent and causing issues during uploads.
For Riscv upload function, ensure required parameters are passed to the new node.